Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom convertor for GeoOrientation to tolerate alternative options in Elasticsearch #3776 #3779

Merged
merged 7 commits into from
Jun 7, 2019

Conversation

codebrain
Copy link
Contributor

Opening to start a conversation on how to implement a JsonFormatter for an enum.

OOTB it looks like UTF8JSON doesnt support placing the attribute on enum values.

Any idea where to go with this? @russcam

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a comment about the lowercasing

src/Nest/Mapping/Types/Geo/GeoShape/GeoOrientation.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left small comment about assertion

@codebrain codebrain merged commit 56a3ac0 into 7.x Jun 7, 2019
@Mpdreamz Mpdreamz deleted the feature/7.x-geoorientation branch June 17, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants